Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 3 Regressions on 1/6/2023 8:14:14 AM #11472

Closed
performanceautofiler bot opened this issue Jan 10, 2023 · 0 comments
Closed

[Perf] Windows/x64: 3 Regressions on 1/6/2023 8:14:14 AM #11472

performanceautofiler bot opened this issue Jan 10, 2023 · 0 comments

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 1801b56a60576cdd156134ad80872dbf984e62e7
Compare c2469455eab98fdcea71997d3cc5004a992fc88f
Diff Diff

Regressions in System.Diagnostics.Perf_Activity

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
EnumerateActivityLinksLarge - Duration of single invocation 18.01 μs 19.00 μs 1.06 0.16 False
EnumerateActivityTagsLarge - Duration of single invocation 7.63 μs 8.81 μs 1.15 0.27 False

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Diagnostics.Perf_Activity*'

Payloads

Baseline
Compare

Histogram

System.Diagnostics.Perf_Activity.EnumerateActivityLinksLarge


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 19.001802745664744 > 18.473344046677212.
IsChangePoint: Marked as a change because one of 11/11/2022 5:53:56 PM, 11/16/2022 6:51:59 PM, 12/21/2022 9:23:17 AM, 12/28/2022 5:13:50 PM, 1/6/2023 5:32:27 AM, 1/10/2023 7:48:18 AM falls between 1/1/2023 3:57:25 AM and 1/10/2023 7:48:18 AM.
IsRegressionStdDev: Marked as regression because -7.993558711113361 (T) = (0 -20347.44236639447) / Math.Sqrt((306125.4583644331 / (31)) + (1392290.5597950395 / (17))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (31) + (17) - 2, .025) and -0.13508941943240746 = (17925.84973311534 - 20347.44236639447) / 17925.84973311534 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Diagnostics.Perf_Activity.EnumerateActivityTagsLarge

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 8.81253464203233 > 8.028710802659893.
IsChangePoint: Marked as a change because one of 11/18/2022 8:48:12 PM, 11/29/2022 2:55:01 PM, 1/7/2023 12:45:06 AM, 1/10/2023 7:48:18 AM falls between 1/1/2023 3:57:25 AM and 1/10/2023 7:48:18 AM.
IsRegressionStdDev: Marked as regression because -10.987515142370894 (T) = (0 -9528.08312797321) / Math.Sqrt((176912.92077972653 / (35)) + (219648.51128446564 / (13))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (13) - 2, .025) and -0.2060561645605624 = (7900.1985213888065 - 9528.08312797321) / 7900.1985213888065 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS Windows 10.0.19042
Baseline 1801b56a60576cdd156134ad80872dbf984e62e7
Compare c2469455eab98fdcea71997d3cc5004a992fc88f
Diff Diff

Regressions in System.Collections.IterateForEach<String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ReadOnlySpan - Duration of single invocation 152.95 ns 290.18 ns 1.90 0.01 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.IterateForEach&lt;String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.IterateForEach<String>.ReadOnlySpan(Size: 512)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 290.18170314225557 > 160.59572594038863.
IsChangePoint: Marked as a change because one of 1/6/2023 5:32:27 AM, 1/10/2023 7:48:18 AM falls between 1/1/2023 3:57:25 AM and 1/10/2023 7:48:18 AM.
IsRegressionStdDev: Marked as regression because -1395.566461067694 (T) = (0 -290.49105960536184) / Math.Sqrt((0.2650850199193287 / (31)) + (0.018463495878278974 / (17))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (31) + (17) - 2, .025) and -0.8925826528195163 = (153.48923291281173 - 290.49105960536184) / 153.48923291281173 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants