Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update centos7 image to net image #3004

Merged
merged 8 commits into from
May 10, 2023
Merged

Update centos7 image to net image #3004

merged 8 commits into from
May 10, 2023

Conversation

LoopedBard3
Copy link
Member

Centos is not being supported in net8 because it doesn't have up to date GLIBCXX files. Initial issue figuring this out: dotnet/sdk#31893, additional information: dotnet/runtime#83428

@LoopedBard3 LoopedBard3 added bug Something isn't working pipeline blocker issue blocks perf pipeline stays green. This be considered high priority. labels May 3, 2023
@LoopedBard3 LoopedBard3 self-assigned this May 3, 2023
@LoopedBard3 LoopedBard3 changed the title Try changing centos 7 to use mariner 2.0. Update centos7 image to net image May 9, 2023
@LoopedBard3 LoopedBard3 marked this pull request as ready for review May 9, 2023 16:27
@LoopedBard3
Copy link
Member Author

@adamsitnik CentOS appears to have been chosen as a part of #2328. I am wondering if you are aware of any specific reasons CentOS was chosen over other containers, such as the ubuntu one this would change the run to? Thanks!

cincuranet
cincuranet approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we should probably notify interested parties for possible changes in numbers from the OS change.

@adamsitnik
Copy link
Member

I am wondering if you are aware of any specific reasons CentOS was chosen over other containers, such as the ubuntu one this would change the run to?

TBH I did not remember the reason, but from the list of my commits of shame where I was trying to get it working I can see that it just had all native dependencies in place:

image

adamsitnik
adamsitnik approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @LoopedBard3 !

@adamsitnik
Copy link
Member

although we should probably notify interested parties for possible changes in numbers from the OS change.

afaik this CI leg was used only for verification that all benchmarks can be compiler and executed for NativeAOT.

@adamsitnik
Copy link
Member

I'll merge it to unblock other PRs

@adamsitnik adamsitnik merged commit 51a0ba0 into dotnet:main May 10, 2023
@LoopedBard3 LoopedBard3 deleted the SwitchFromCentosToMariner branch December 6, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincuranet cincuranet cincuranet approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@sblom sblom Awaiting requested review from sblom

@caaavik-msft caaavik-msft Awaiting requested review from caaavik-msft

Assignees

@LoopedBard3 LoopedBard3

Labels
bug Something isn't working pipeline blocker issue blocks perf pipeline stays green. This be considered high priority.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LoopedBard3 @adamsitnik @cincuranet