Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion right after @bind$$-Parameter does not overwrite existing parameter #9756

Closed
Tracked by #9807
Peter-Juhasz opened this issue Dec 22, 2023 · 5 comments
Closed
Tracked by #9807
Assignees
Labels
bug Something isn't working feature-completion

Comments

@Peter-Juhasz
Copy link

Version: VS 17.9.0 P2

Instead of overwriting, it keeps inserting the parameter name:

Rogzites.2023-12-22.091703.mp4

Similar to #9755, but not exactly the same. The underlying cause may be common (selecting the wrong completion span in text?), but it results in a different effect.

@alexgav
Copy link
Contributor

alexgav commented Mar 8, 2024

@Peter-Juhasz thank you for the detailed video! Unfortunately I am unable to reproduce using a similar component. Would you be able to share a simple project that reproduces that issue for you? I am also unable to reproduce #9755 , so as you mentioned they might be related.

@Peter-Juhasz
Copy link
Author

I can't share the project, but you can see the whole file in the recording.

It happens in multiple files and projects. Right now, I'm trying to reproduce it, but I don't even get any completions for a @bind-Property, which is either another symptom (sometimes happens this, sometimes happens that), another bug (which hides the one recorded in this issue), or it was accidentally "fixed" to a behavior which is not consistent with the C# experience (so that no completions are shown, but the caret doesn't move to the end of the completion span)?

@alexgav
Copy link
Contributor

alexgav commented Mar 15, 2024

@Peter-Juhasz , thank you for your response. Am I understanding correctly that you are unable to reproduce duplicate text insertion anymore? I understand there may be other issues present, but want to focus on the duplicate text insertion (instead of text replacement) in this issue.

I did watch the video and I understand the issue was present in the past (it was also internally reported). However neither I nor other team members are able to reproduce it anymore, so I am assuming this particular issue is fixed (unless you can provide a project or page that still reproduces it). Please let me know!

We do appreciate the issues you report and the time you take to record the videos, it is very much appreciated and I want to make sure we are doing the due diligence here. However without being able to reproduce the issue, I cannot investigate this any further.

@Peter-Juhasz
Copy link
Author

Sure, feel free to close it, it was not a high priority one and we can reopen it later if it comes up again. Thanks for the time anyway!

@alexgav
Copy link
Contributor

alexgav commented Mar 19, 2024

Closing as I believe it was fixed by the VS platform changes (likely underling cause might have been non-alphanumeric character in the applicable-to span or completion text)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature-completion
Projects
None yet
Development

No branches or pull requests

3 participants