Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compat workaround for interceptors file path lookup. #72265

Closed
RikkiGibson opened this issue Feb 24, 2024 · 4 comments
Closed

Remove compat workaround for interceptors file path lookup. #72265

RikkiGibson opened this issue Feb 24, 2024 · 4 comments

Comments

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Feb 24, 2024

Related to #71879
https://github.com/dotnet/roslyn/blob/main/docs/features/interceptors.md

Temporarily, for compatibility purposes, when the initial matching strategy outlined above fails to match any syntax trees, we will fall back to a "compat" matching strategy which works in the following way:

  • A mapped path of each syntax tree is determined by applying /pathmap substitution to SyntaxTree.FilePath.
  • For a given [InterceptsLocation] usage, the filePath argument value is compared to the mapped path of each syntax tree using ordinal string comparison. If exactly one syntax tree matches under this comparison, that is the referenced syntax tree. Otherwise, an error occurs.

Support for the "compat" strategy will be dropped prior to stable release.

Note: this issue is referenced in src/doc

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 24, 2024
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 12, 2024
@jaredpar jaredpar added this to the 17.11 milestone Mar 12, 2024
@RikkiGibson
Copy link
Contributor Author

Maybe we will end up using this issue to track entirely removing path-based interceptors (in favor of checksum-based.)

@jaredpar jaredpar modified the milestones: 17.11, .NET 9 Apr 15, 2024
@jaredpar jaredpar modified the milestones: .NET 9, 17.12 Jul 9, 2024
@jaredpar
Copy link
Member

jaredpar commented Jul 9, 2024

@RikkiGibson check to see if we still need this.

@RikkiGibson
Copy link
Contributor Author

if we are removing this at the same time as filepath-line-col then close htis issue out and refer to it over there

@RikkiGibson
Copy link
Contributor Author

The filepath-line-column scheme will be completely removed when support for .NET 8 is dropped, which means this compat workaround will also be removed at that time. #72855

@RikkiGibson RikkiGibson closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants