Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE0052 violation is not failing the build #76994

Closed
Youssef1313 opened this issue Feb 1, 2025 · 2 comments
Closed

IDE0052 violation is not failing the build #76994

Youssef1313 opened this issue Feb 1, 2025 · 2 comments
Labels
Area-IDE

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Feb 1, 2025 •
edited
Loading

See microsoft/testfx#4845

We already treat warnings as errors, and are already setting IDE0052 as warning

https://github.com/microsoft/testfx/blob/5134979a76d84c23bff7cea65128348dd67e9598/.editorconfig#L152

We are also setting EnforceCodeStyleInBuild:

https://github.com/microsoft/testfx/blob/5134979a76d84c23bff7cea65128348dd67e9598/eng/Analyzers.props#L7

However, build is green already without the changes from microsoft/testfx#4845

I don't have a minimal repro so far :(
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 1, 2025
@Youssef1313
Copy link
Member Author

microsoft/testfx#4895 is another case where the analyzer fails to produce a warning.

@Youssef1313
Copy link
Member Author

Looks like we may be encountering the bug that was recently fixed in #76335

@dotnet-policy-service dotnet-policy-service bot removed the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Youssef1313