Skip to content

Commit

Permalink
Remove bbFallsThrough checks in fgNewBBbefore/after (#99636)
Browse files Browse the repository at this point in the history
Now that implicit fallthrough is gone, it doesn't make sense to mark a new block as rarely run if the previous block is rarely run, as there's no guarantee the previous block flows into the next. It would make more sense to rely on the weights of a block's predecessor edges to determine if it's rarely run.
  • Loading branch information
amanasifkhalid authored Mar 14, 2024
1 parent b54c555 commit 713e690
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions src/coreclr/jit/fgbasic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6012,11 +6012,6 @@ BasicBlock* Compiler::fgNewBBbefore(BBKinds jumpKind, BasicBlock* block, bool ex

newBlk->bbRefs = 0;

if (newBlk->bbFallsThrough() && block->isRunRarely())
{
newBlk->bbSetRunRarely();
}

if (extendRegion)
{
fgExtendEHRegionBefore(block);
Expand Down Expand Up @@ -6051,11 +6046,6 @@ BasicBlock* Compiler::fgNewBBafter(BBKinds jumpKind, BasicBlock* block, bool ext

newBlk->bbRefs = 0;

if (block->bbFallsThrough() && block->isRunRarely())
{
newBlk->bbSetRunRarely();
}

if (extendRegion)
{
fgExtendEHRegionAfter(block);
Expand Down

0 comments on commit 713e690

Please sign in to comment.