Mark some Nullable<T> members as readonly (#1727)

Value, HasValue, GetValueOrDefault
dotnet · Jan 15, 2020 · 92025b2 · 92025b2
1 parent 4de18d6
commit 92025b2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Nullable.cs b/src/libraries/System.Private.CoreLib/src/System/Nullable.cs
@@ -26,13 +26,13 @@ public Nullable(T value)
             hasValue = true;
         }
 
-        public bool HasValue
+        public readonly bool HasValue
         {
             [NonVersionable]
             get => hasValue;
         }
 
-        public T Value
+        public readonly T Value
         {
             get
             {
@@ -45,10 +45,10 @@ public T Value
         }
 
         [NonVersionable]
-        public T GetValueOrDefault() => value;
+        public readonly T GetValueOrDefault() => value;
 
         [NonVersionable]
-        public T GetValueOrDefault(T defaultValue) =>
+        public readonly T GetValueOrDefault(T defaultValue) =>
             hasValue ? value : defaultValue;
 
         public override bool Equals(object? other)

diff --git a/src/libraries/System.Runtime/ref/System.Runtime.cs b/src/libraries/System.Runtime/ref/System.Runtime.cs
@@ -1911,12 +1911,12 @@ public partial struct Nullable<T> where T : struct
         private T value;
         private int _dummyPrimitive;
         public Nullable(T value) { throw null; }
-        public bool HasValue { get { throw null; } }
-        public T Value { get { throw null; } }
+        public readonly bool HasValue { get { throw null; } }
+        public readonly T Value { get { throw null; } }
         public override bool Equals(object? other) { throw null; }
         public override int GetHashCode() { throw null; }
-        public T GetValueOrDefault() { throw null; }
-        public T GetValueOrDefault(T defaultValue) { throw null; }
+        public readonly T GetValueOrDefault() { throw null; }
+        public readonly T GetValueOrDefault(T defaultValue) { throw null; }
         public static explicit operator T (T? value) { throw null; }
         public static implicit operator T? (T value) { throw null; }
         public override string? ToString() { throw null; }