Define JIT format jobs as GitHub Actions instead of AzDO jobs (#103846)

dotnet · Jun 24, 2024 · 98e7570 · 98e7570
1 parent 7df87e8
commit 98e7570
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 90 deletions.
diff --git a/.github/workflows/jit-format.yml b/.github/workflows/jit-format.yml
@@ -0,0 +1,55 @@
+on:
+  pull_request:
+    paths:
+      - 'src/coreclr/jit/**'
+    branches: [ main ]
+
+jobs:
+  format:
+    strategy:
+      matrix:
+        os:
+          - name: linux
+            image: ubuntu-latest
+            container: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-cross-amd64-net9.0
+            extension: '.sh'
+            cross: '--cross'
+          - name: windows
+            image: windows-latest
+            extension: '.cmd'
+            cross: ''
+    runs-on: ${{ matrix.os.image }}
+    container: ${{ matrix.os.container }}
+    steps:
+      - name: Checkout jitutils
+        uses: actions/checkout@v4
+        with:
+          path: jitutils
+          repository: dotnet/jitutils
+          ref: main
+          token: ${{ secrets.GITHUB_TOKEN }}
+      - name: Install .NET
+        uses: actions/setup-dotnet@v1
+        with:
+          dotnet-version: '8.0.x'
+      - name: Build jitutils
+        run: |
+          cd jitutils
+          ./bootstrap${{ matrix.os.extension }}
+      - name: Checkout runtime
+        uses: actions/checkout@v4
+        with:
+          path: runtime
+      - name: Install Python
+        uses: actions/setup-python@v5
+
+      - name: Run jitformat.py
+        run: |
+          python3 runtime/src/coreclr/scripts/jitformat.py --jitutils jitutils -r ${{ github.workspace }}/runtime -o ${{ matrix.os.name }} -a x64 ${{ matrix.os.cross }}
+      
+      - name: Publish format.patch
+        uses: actions/upload-artifact@v2
+        with:
+          path: format.patch
+          name: format.${{matrix.os.name}}.patch
+        if: failure()
diff --git a/eng/pipelines/common/evaluate-default-paths.yml b/eng/pipelines/common/evaluate-default-paths.yml
@@ -202,9 +202,6 @@ jobs:
       - src/coreclr/jit/*
       - src/coreclr/pal/*
       - src/coreclr/vm/*
-    - subset: coreclr_jit
-      include:
-      - src/coreclr/jit/*
 
     #
     # ** WASM **

diff --git a/eng/pipelines/coreclr/templates/format-job.yml b/eng/pipelines/coreclr/templates/format-job.yml
diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml
@@ -442,27 +442,6 @@ extends:
                 eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_runtimetests.containsChange'], true),
                 eq(variables['isRollingBuild'], true))
 
-      #
-      # Build CoreCLR Formatting Job
-      # Only when CoreCLR is changed, and only in the 'main' branch (no release branches;
-      # both Rolling and PR builds).
-      #
-      - template: /eng/pipelines/common/platform-matrix.yml
-        parameters:
-          jobTemplate: /eng/pipelines/coreclr/templates/format-job.yml
-          platforms:
-          - linux_x64
-          - windows_x64
-          jobParameters:
-            condition: >-
-              and(
-                or(
-                  eq(variables['Build.SourceBranchName'], 'main'),
-                  eq(variables['System.PullRequest.TargetBranch'], 'main')),
-                or(
-                  eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_coreclr_jit.containsChange'], true),
-                  eq(variables['isRollingBuild'], true)))
-
       #
       # Build CoreCLR with no R2R
       #