Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable more networking tests for innerloop #18406

Closed
davidsh opened this issue Sep 1, 2016 · 6 comments · Fixed by dotnet/corefx#15952
Closed

Re-enable more networking tests for innerloop #18406

davidsh opened this issue Sep 1, 2016 · 6 comments · Fixed by dotnet/corefx#15952
Labels
area-System.Net
Milestone
2.0.0

Comments

@davidsh
Copy link
Contributor

davidsh commented Sep 1, 2016

PR dotnet/corefx#11341 moved the majority of networking tests to outerloop due to infrastructure issues. This issue will track putting back tests as we strengthen the test infrastructure to allow more networking tests to run as innerloop.
@davidsh davidsh self-assigned this Sep 1, 2016
@davidsh davidsh removed their assignment Nov 18, 2016
@ianhays ianhays reopened this Feb 9, 2017
ianhays referenced this issue in dotnet/corefx Feb 9, 2017
Test cleanup for System.Net.Security (#15952)
02b0fdb 
* Test cleanup for System.Net.Security

#3144 - Removed TODO because Begin/End were added back in #8358 and the issue is closed
#7825 - Original issue from April 2016. Cannot repro today. Re-enabling to watch for future failures.
#11170 - Can't repro failures on multiple OSs. Re-enabling to watch for future failures.
#11345 - Outerloop tests are passing and stable for thousands of iterations. Tentatively moving to innerloop to watch for potential future failures.
#12107 - removed TODO because issue is closed
#9130, #10909, #11624, #14177, #14505 - duplicate issues failing because of an intermittent error (remote party closed transport stream) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.
#8744, #12683, #12706, #12728 - duplicate issues failing because of an intermittent error (credentials package not recognized) not exclusive to the test which occurs in Outerloop runs for other NetSecurity tests. Re-enabling them and leaving them in innerloop to get more data.

* Remove unused netsecurity tests helper

* Remove unused test helper
@davidsh
Copy link
Contributor Author

davidsh commented Feb 26, 2017 •
edited by antonfirsov
Loading

Tracking networking test reliability with #19687.

@davidsh davidsh closed this as completed Feb 26, 2017
@ViktorHofer
Copy link
Member

ViktorHofer commented May 9, 2017 •
edited
Loading

FtpWebRequestTests test class has plenty of methods which run on Outerloop and have a comment which pointed me here. Is this still an issue or should we try removing the Outerloop?

@davidsh
Copy link
Contributor Author

davidsh commented May 9, 2017

Pls leave Outerloop as-is. In general, networking tests which access a remote endpoint or even loopback still need to be outerloop for now.

@davidsh
Copy link
Contributor Author

davidsh commented May 9, 2017

This issue probably shouldn't be marked 2.0 though.

@karelz Why is this issue 2.0? At this point, we are not ready yet to move all networking tests to inner loop.

@davidsh
Copy link
Contributor Author

davidsh commented May 9, 2017

@karelz Why is this issue 2.0? At this point, we are not ready yet to move all networking tests to inner loop.

Oh. Never mind. I see that this issue is closed. So, no action required. Thx.

@karelz
Copy link
Member

karelz commented May 9, 2017

BTW: I set milestones on issues which are closed, so that it is easy to find out when they were fixed / resolved as won't fix, etc.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Test cleanup for System.Net.Security
5 participants
@ianhays @karelz @ViktorHofer @davidsh @msftgits