Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sse2.MoveMask that takes Vector128<byte> #24721

Closed
eerhardt opened this issue Jan 19, 2018 · 3 comments · Fixed by dotnet/coreclr#15923
Closed

Add Sse2.MoveMask that takes Vector128<byte> #24721

eerhardt opened this issue Jan 19, 2018 · 3 comments · Fixed by dotnet/coreclr#15923
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.Runtime.Intrinsics
Milestone
2.1.0

Comments

@eerhardt
Copy link
Member

Today we have overloads for Avx2.MoveMask for both sbyte and byte vectors.

  • Avx2.MoveMask(Vector256<sbyte> value)
  • Avx2.MoveMask(Vector256<byte> value)

but for Sse2, we only have overloads for sbyte.

  • Sse2.MoveMask(Vector128<sbyte> value)

We should add an Sse2.MoveMask overload that takes a Vector128<byte> as well.

/cc @fiigii @tannergooding @CarolEidt
@tannergooding
Copy link
Member

Does this necessarily qualify as an API-suggestion? I would think it was one of the already approved APIs that was missed due to different review process taken for these APIs...

@fiigii
Copy link
Contributor

fiigii commented Jan 19, 2018

I would think it was one of the already approved APIs that was missed due to different review process taken for these APIs...

Yes, My apologies...

@eerhardt
Copy link
Member Author

Does this necessarily qualify as an API-suggestion?

No, I don't think this has to go through the full API review process. It should have been included in the initial review. I just wanted to ensure people saw this as an "API modifying" issue.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.Runtime.Intrinsics
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Fixing some inconsistencies in the x86 HWIntrinsic APIs
4 participants
@fiigii @eerhardt @msftgits @tannergooding