Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a code coverage bot to PRs #27562

Closed
ViktorHofer opened this issue Oct 7, 2018 · 2 comments
Closed

Add a code coverage bot to PRs #27562

ViktorHofer opened this issue Oct 7, 2018 · 2 comments
Assignees
@ViktorHofer
Labels
area-Infrastructure-libraries
Milestone
3.0

Comments

@ViktorHofer
Copy link
Member

After the migration to Coverlet is done we should consider adding a code coverage bot that runs on PRs. There's also the option to fail the job if the coverage decreased.

Example from coverlet-coverage/coverlet#105:

image

cc @danmosemsft @pjanotti
@ericstj
Copy link
Member

ericstj commented Mar 27, 2019

@safern mentioned that we need codecov builds for every PR first to do this. Right now that is pending a story for using secrets in public PR builds.

@ViktorHofer
Copy link
Member Author

Closing in favor of https://github.com/dotnet/corefx/issues/34886

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@ViktorHofer @ericstj @msftgits