Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 11/12/2021 4:32:49 AM #61785

Closed
Tracked by #79004
performanceautofiler bot opened this issue Nov 18, 2021 · 4 comments
Closed
Tracked by #79004

[Perf] Changes at 11/12/2021 4:32:49 AM #61785

performanceautofiler bot opened this issue Nov 18, 2021 · 4 comments
Assignees
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline c737141bb34914afd47c2896ee0867ee47e86ad2
Compare 35704e44e5d1b158f21512b1c1081a0e025bde3f
Diff Diff

Regressions in System.Numerics.Tests.Perf_VectorConvert

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Widen_float - Duration of single invocation 803.36 ns 867.53 ns 1.08 0.12 True

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Numerics.Tests.Perf_VectorConvert*'

Payloads

Baseline
Compare

Histogram

System.Numerics.Tests.Perf_VectorConvert.Widen_float


Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Nov 18, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 18, 2021
@DrewScoggins DrewScoggins added arch-arm64 os-windows tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Nov 18, 2021
@DrewScoggins
Copy link
Member

Related to #60094

@ghost
Copy link

ghost commented Nov 21, 2021

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline c737141bb34914afd47c2896ee0867ee47e86ad2
Compare 35704e44e5d1b158f21512b1c1081a0e025bde3f
Diff Diff

Regressions in System.Numerics.Tests.Perf_VectorConvert

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Widen_float - Duration of single invocation 803.36 ns 867.53 ns 1.08 0.12 True

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Numerics.Tests.Perf_VectorConvert*'

Payloads

Baseline
Compare

Histogram

System.Numerics.Tests.Perf_VectorConvert.Widen_float


Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

arch-arm64, area-System.Numerics, os-windows, tenet-performance, tenet-performance-benchmarks, untriaged

Milestone: -

@tannergooding tannergooding removed the untriaged New issue has not been triaged by the area owner label Mar 14, 2022
@jeffhandley jeffhandley added this to the 7.0.0 milestone Jul 10, 2022
@dakersnar dakersnar modified the milestones: 7.0.0, 8.0.0 Aug 8, 2022
@tannergooding
Copy link
Member

There were some generalizations made to IR we import to make the overall code more maintainable and optimizable for common patterns. We just happen to minorly regress this scenario where we're benchmarking only this instruction in a tight loop

@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants