You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we re-jit a R2R'd code we hit HandleCallCountingForFirstCall where we set m_tier1CallCountingCandidateMethodRecentlyRecorded = true to delay call-counting installation further, see here.
It seems to me that we should not do that when we already have R2R'd version installed, a proper fix is
if (!ExecutionManager::IsReadyToRunCode(pMethodDesc->GetNativeCode()))
{
// Delay call counting for currently recoded methods furtherm_tier1CallCountingCandidateMethodRecentlyRecorded= true;
}
However, ExecutionManager::IsReadyToRunCode is likely not cheap due to #8393 issue 😞
The problem, it should help with, is: when we start a large app we constantly compile something and VM simply doesn't have a window to install call counting stubs for methods, even extremely hot ones - they might stuck un-counted in Tier0 for seconds, see #70941 (comment)
The text was updated successfully, but these errors were encountered:
ghost
added
the
untriaged
New issue has not been triaged by the area owner
label
Oct 29, 2022
When we re-jit a R2R'd code we hit
HandleCallCountingForFirstCall
where we setm_tier1CallCountingCandidateMethodRecentlyRecorded = true
to delay call-counting installation further, see here.It seems to me that we should not do that when we already have R2R'd version installed, a proper fix is
However,
ExecutionManager::IsReadyToRunCode
is likely not cheap due to #8393 issue 😞The problem, it should help with, is: when we start a large app we constantly compile something and VM simply doesn't have a window to install call counting stubs for methods, even extremely hot ones - they might stuck un-counted in Tier0 for seconds, see #70941 (comment)
The text was updated successfully, but these errors were encountered: