Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address feedback from initial config binding generator PR #83531

Closed
layomia opened this issue Mar 16, 2023 · 3 comments · Fixed by #84737
Closed

Address feedback from initial config binding generator PR #83531

layomia opened this issue Mar 16, 2023 · 3 comments · Fixed by #84737
Assignees
@layomia
Labels
area-Extensions-Configuration source-generator Indicates an issue with a source generator feature
Milestone
8.0.0

Comments

@layomia
Copy link
Contributor

layomia commented Mar 16, 2023

Address all feedback not resolved in PR #82179.
@layomia layomia added area-Extensions-Configuration source-generator Indicates an issue with a source generator feature labels Mar 16, 2023
@layomia layomia added this to the 8.0.0 milestone Mar 16, 2023
@layomia layomia self-assigned this Mar 16, 2023
@ghost
Copy link

ghost commented Mar 16, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Address all feedback not resolved in PR #82179.

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration, source-generator
Milestone: 8.0.0

@layomia layomia mentioned this issue Mar 16, 2023
Closed
12 tasks
@Tornhoof
Copy link
Contributor

@eiriktsarpalis in #82179 (comment) you wrote that "IncrementalValuesProvider also has a RegisterSourceOutput which can be triggered independently for each of its components without forcing recalculation of the others."

Do you have examples? I couldn't find an appropriate extension method.

This was referenced Mar 17, 2023
Closed
Merged
@eiriktsarpalis
Copy link
Member

@Tornhoof the more accurate statement would have been that IncrementalGeneratorInitializationContext has an overload that accepts IncrementalValuesProvider:

https://learn.microsoft.com/en-us/dotnet/api/microsoft.codeanalysis.incrementalgeneratorinitializationcontext.registersourceoutput?view=roslyn-dotnet-4.3.0#microsoft-codeanalysis-incrementalgeneratorinitializationcontext-registersourceoutput-1(microsoft-codeanalysis-incrementalvaluesprovider((-0))-system-action((microsoft-codeanalysis-sourceproductioncontext-0)))

@layomia layomia mentioned this issue Apr 12, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 12, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-Extensions-Configuration source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Address misc feedback for config binder implementation layomia/dotnet_runtime
3 participants
@eiriktsarpalis @Tornhoof @layomia