New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Host should separate arguments for engine, mono and application #88760

Open

pavelsavara opened this issue Jul 12, 2023 · 3 comments

Labels

arch-wasm area-System.Runtime.InteropServices.JavaScript os-browser

Milestone

Member

pavelsavara commented Jul 12, 2023 •

edited by radical

Loading

Possible designs
A) use multiple -- to separate it
node --enable-source-maps main.js -- hello.dll --setenv=XXX=1 -- -fromCity=Prague to Ilona

--enable-source-maps is nodeJS engine flag
--setenv=XXX=1 is mono engine flag
-fromCity=Prague is application argument
to is application arg
Ilona is application arg

dotnet run --engine=node -- --enable-source-maps main.js -- hello.dll --setenv=XXX=1 -- -fromCity=Prague to Ilona

this assumes that main.js which is user will call .withRuntimeOptionsFromArguments() to consume it.

B) use well know pass-thru arguments

wasmtime run --env MONO_OPTIONS="values" dotnet.wasm

dotnet run --engine=wasmtime --engine-arg='--env MONO_OPTIONS="values"' dotnet.wasm

escaping becomes nasty.

Also, from #85674 (comment)
Perhaps there should be pass-thru argument like --host:xxx=yyyand--runtime:aaa=bbbbefore application -- ? As an alternative to multiple -- .

More details discussed here #70892

The text was updated successfully, but these errors were encountered:

pavelsavara added arch-wasm os-browser labels

pavelsavara added this to the 8.0.0 milestone

pavelsavara assigned radical

dotnet-issue-labeler bot added the needs-area-label label

ghost commented Jul 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Possible designs
A) use multiple -- to separate it
node --enable-source-maps main.js -- hello.dll --setenv=XXX=1 -- -fromCity=Prague to Ilona

--enable-source-maps is nodeJS engine flag
--setenv=XXX=1 is mono engine flag
-fromCity=Prague is application argument
to is application arg
Ilona is application arg

dotnet run --engine=node -- --enable-source-maps main.js -- hello.dll --setenv=XXX=1 -- -fromCity=Prague to Ilona

this assumes that main.js which is user will call .withRuntimeOptionsFromArguments() to consume it.

B) use well know pass-thru arguments

wasmtime run --env MONO_OPTIONS="values" dotnet.wasm

dotnet run --engine=wasmtime --engine-arg='--env MONO_OPTIONS="values"' dotnet.wasm

escaping becomes nasty.

More details discussed here #70892

Author:	pavelsavara
Assignees:	radical
Labels:	`arch-wasm`, `os-browser`
Milestone:	8.0.0

maraf mentioned this issue

[wasm] Design application startup, template, configuration #70892

Closed

12 tasks

jeffschwMSFT added the area-System.Runtime.InteropServices.JavaScript label

vcsjones removed the needs-area-label label

pavelsavara mentioned this issue

[wasm] Templates don't pass the command line arguments to the app #76201

Open

3 tasks

lewing assigned maraf and unassigned maraf

radical mentioned this issue

[wasi] Cleanly delineate runtime, and application arguments #85674

Closed

Member

radical commented Aug 14, 2023

Moving this to 9.0, so we can get an agreement on how this should be done, as it should be consistent with how dotnet run handles these kinda cases.

radical modified the milestones: 8.0.0, 9.0.0

Member Author

pavelsavara commented Nov 20, 2023

radical removed their assignment

pavelsavara modified the milestones: 9.0.0, Future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment