Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][mt] Changes broke dotnet build in Http solution #98000

Closed
ManickaP opened this issue Feb 5, 2024 · 5 comments
Closed

[browser][mt] Changes broke dotnet build in Http solution #98000

ManickaP opened this issue Feb 5, 2024 · 5 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Net.Http
Milestone

Comments

@ManickaP
Copy link
Member

ManickaP commented Feb 5, 2024

#97560 broke calling dotnet build in src/libraries/System.Net.Http. It works on the previous commit (I did a binary search to find the exact commit that broke this).

Error:

/home/manicka/repositories/runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/RuntimeInformation.cs(76,8): error CS1029: #error: 'Unknown Architecture' [/home/manicka/repositories/runtime/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]

@ilonatommy PTAL

@ManickaP ManickaP added the arch-wasm WebAssembly architecture label Feb 5, 2024
@lewing lewing added this to the 9.0.0 milestone Feb 5, 2024
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 5, 2024
@ghost
Copy link

ghost commented Feb 5, 2024

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

#97560 broke calling dotnet build in src/libraries/System.Net.Http. It works on the previous commit (I did a binary search to find the exact commit that broke this).

@ilonatommy PTAL

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@ilonatommy
Copy link
Member

ilonatommy commented Feb 6, 2024

@ManickaP, could you please help me reproduce? I tried on new codespaces, main HEAD on 89bba37, I did:

./build.sh mono+libs -c release -os browser
cd src/libraries/System.Net.Http
dotnet build

and it finished with success, no errors. What am I doing wrong?

@ManickaP
Copy link
Member Author

ManickaP commented Feb 6, 2024

I use ./build.sh clr+libs -rc release. I'm also on Linux if that plays any role. And my globally installed dotnet is:

.NET SDK:
 Version:           9.0.100-alpha.1.24068.28
 Commit:            cc3d47d4cb
 Workload version:  9.0.100-manifests.745f81b6

Runtime Environment:
 OS Name:     arch
 OS Version:
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /usr/share/dotnet/sdk/9.0.100-alpha.1.24068.28/

.NET workloads installed:
There are no installed workloads to display.

Host:
  Version:      9.0.0-alpha.1.24061.26
  Architecture: x64
  Commit:       22ba7d607b

@pavelsavara
Copy link
Member

cc @ViktorHofer

@ManickaP
Copy link
Member Author

ManickaP commented Feb 6, 2024

Ok, so this is somehow fixed in main. I did another search and it was fixed by : cb0e160

@ManickaP ManickaP closed this as completed Feb 6, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Feb 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net.Http
Projects
None yet
Development

No branches or pull requests

4 participants