Fix a nested-externs warning in mono #104817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```sh
In file included from /runtime/src/native/eventpipe/ep-rt.h:741,
from /runtime/src/native/eventpipe/ep-stack-contents.h:7,
from /runtime/src/native/eventpipe/ep.h:8,
from /runtime/src/native/eventpipe/ep.c:7,
from /runtime/artifacts/obj/mono/illumos.x64.Release/mono/mini/CMakeFiles/eventpipe-mono-objects.dir/Unity/unity_0_c.c:3:
/runtime/src/mono/mono/mini/../../mono/eventpipe/ep-rt-mono.h: In function 'ep_rt_mono_is_runtime_initialized':
/runtime/src/mono/mono/mini/../../mono/eventpipe/ep-rt-mono.h:1996:18: warning: nested extern declaration of '_ep_rt_mono_runtime_initialized' [-Wnested-externs]
extern gboolean _ep_rt_mono_runtime_initialized;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
dotnet-policy-service
bot
added
the
community-contribution
lambdageek
approved these changes
Jul 12, 2024
|
/cc @mdh1418 |
mdh1418
approved these changes
Jul 12, 2024
This was referenced Jul 13, 2024
Open
|
@dotnet-bot retest this please |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tommcdon, fyi, when i merged |
This was referenced Aug 7, 2024
|
@lewing can you confirm that the wasm tests are flaky and not side effect of this PR? |
|
@pavelsavara can you please confirm that the wasm tests are flaky and not side effect of this PR? |
|
if the build analysis step is green (it is) that is sufficient confirmation |
|
Yes, they are flaky. |
|
Feel free to merge this, I don't have the merge rights. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file included from /runtime/src/native/eventpipe/ep-rt.h:741, from /runtime/src/native/eventpipe/ep-stack-contents.h:7, from /runtime/src/native/eventpipe/ep.h:8, from /runtime/src/native/eventpipe/ep.c:7, from /runtime/artifacts/obj/mono/illumos.x64.Release/mono/mini/CMakeFiles/eventpipe-mono-objects.dir/Unity/unity_0_c.c:3: /runtime/src/mono/mono/mini/../../mono/eventpipe/ep-rt-mono.h: In function 'ep_rt_mono_is_runtime_initialized': /runtime/src/mono/mono/mini/../../mono/eventpipe/ep-rt-mono.h:1996:18: warning: nested extern declaration of '_ep_rt_mono_runtime_initialized' [-Wnested-externs] extern gboolean _ep_rt_mono_runtime_initialized; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .... In file included from /runtime/src/native/containers/dn-fwd-list.c:26: /runtime/src/native/containers/dn-fwd-list.h: In function 'dn_fwd_list_before_begin': /runtime/src/native/containers/dn-fwd-list.h:183:28: warning: nested extern declaration of '_fwd_list_before_begin_it_node' [-Wnested-externs] extern dn_fwd_list_node_t _fwd_list_before_begin_it_node; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~