-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Arm64] Implement BitwiseSelect hardware intrinsic #472
Merged
echesakov
merged 9 commits into
dotnet:master
from
echesakov:AArch64/HWIntrinsics/BitwiseSelect
Dec 5, 2019
Merged
[Arm64] Implement BitwiseSelect hardware intrinsic #472
echesakov
merged 9 commits into
dotnet:master
from
echesakov:AArch64/HWIntrinsics/BitwiseSelect
Dec 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b28a6af
to
498bd2d
Compare
@CarolEidt @TamarChristinaArm @tannergooding PTAL |
CarolEidt
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one minor question
src/coreclr/tests/src/JIT/HardwareIntrinsics/Arm/Shared/GenerateTests.csx
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-arm64
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
BitwiseSelect
Arm64 intrinsic.This one is interesting since as it was proposed in https://github.com/dotnet/corefx/issues/26181 the C# intrinsic method can be implemented to choose between one of the three different instructions bsl, bit, bif depending on the allocated destination register (this can be op1Reg, op2Reg, op3Reg, or some other register).
Below I demonstrate how this works:
In Bsl() case op1Reg is dead after the intrinsic call and can be used as a destination register.
In Bit() case op1Reg and op2Reg are live and LSRA allocates op3Reg as a destination register.
In Bif() case op1Reg and op3Reg are live and LSRA allocates op2Reg as a destination register.
In MovBsl() all three op1Reg, op2Reg and op3Reg are live and v19 is allocated as destination register.
Fixes https://github.com/dotnet/corefx/issues/26181