-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use static abstract interface methods in SymbolicRegexMatcher #61631
Conversation
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions Issue Details@tannergooding, @davidwrighton, any reason not to start relying on static abstract interface methods?
|
@stephentoub, still waiting on some Mono and Crossgen2 fixes before we can: #60905 (comment)
CC. @lambdageek, @akoeplinger |
Thanks, Tanner. Presumably CI will fall over with this then? 😄 |
From @lambdageek's comments on the other issue, it seems like this isn't a problem as it relates to this PR (which doesn't try to take the address of such a method). What about crossgen2? CI passed; does that mean we're not crossgen'ing these assemblies as part of this build, or that any such use will cause crossgen to fail and we simply then always JIT that assembly, or something else? |
@jkotas ? |
Right, libraries CI tests are not crossgening anything under libraries. I expect that we will see outer loop crossgen legs failing at least. We may see other failure modes as well, not sure. I think we really need to finish the crossgen support before we start using this feature in libraries. |
That's fine. Do we know when that will happen? If soon, I'll leave this open. Otherwise, I'll close it. |
/azp list |
/azp run runtime-coreclr crossgen2 outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
This isn't actionable right now. Will revisit once crossgen supports it. |
@tannergooding, @davidwrighton, any reason not to start relying on static abstract interface methods?
cc: @joperezr, @olsaarik