Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use property AutoreleasePoolSupport in test #76800

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Use property AutoreleasePoolSupport in test #76800

merged 1 commit into from
Oct 11, 2022

Conversation

AustinWise
Copy link
Contributor

The SDK also sets the RuntimeHostConfigurationOption item. So setting in this project results in multiple copies of the same item.

This MSBuild property is documented here.

I'm not sure if this causes a problem with any currently supported configuration of .NET, but it is detectable when compiling this test with NativeAOT. ILC fails because multiple copies of the --appcontextswitch flag are passed with the same key.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 10, 2022
@ghost
Copy link

ghost commented Oct 10, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

The SDK also sets the RuntimeHostConfigurationOption item. So setting in this project results in multiple copies of the same item.

This MSBuild property is documented here.

I'm not sure if this causes a problem with any currently supported configuration of .NET, but it is detectable when compiling this test with NativeAOT. ILC fails because multiple copies of the --appcontextswitch flag are passed with the same key.

Author: AustinWise
Assignees: -
Labels:

area-System.Runtime.InteropServices, community-contribution
Milestone: -

This was referenced Oct 10, 2022
Closed
Closed
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the CI is green, I am good with this. Thanks!

@AaronRobinsonMSFT
Copy link
Member

/cc @MichalStrehovsky since this impacts NativeAOT testing.

@AustinWise
Copy link
Contributor Author

Error in the OSX pipeline was "The organization is currently offline for migration". Maybe closing and reopening will re-run the tests?

@AustinWise AustinWise closed this Oct 10, 2022
@AustinWise AustinWise reopened this Oct 10, 2022
@AustinWise
Use property AutoreleasePoolSupport in test
64b2f81 
The SDK also set the RuntimeHostConfigurationOption item.
So setting in this project results in multiple copies of the same item.

I'm not sure if this causes a problem with any currently supported
configuration of .NET, but it is detectable when compiling this test
with NativeAOT. ILC fails because multiple copies of the
`--appcontextswitch` flag are passed with the same key.
@AustinWise AustinWise force-pushed the austin/AutoReleaseProjectConfig branch from 95d14af to 64b2f81 Compare October 10, 2022 16:55
@AustinWise
Copy link
Contributor Author

I also filed dotnet/sdk#28568. You can have multiple RuntimeHostConfigurationOption items for the same switch and get no warning or error when building or publishing.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit daa88f6 into dotnet:main Oct 11, 2022
@AustinWise AustinWise deleted the austin/AutoReleaseProjectConfig branch October 11, 2022 03:40
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.InteropServices community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AustinWise @AaronRobinsonMSFT