-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] fix aotProfiler init #79651
[wasm] fix aotProfiler init #79651
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis is also wrong on Net7 but I think we don't need to backport it.
|
How does this manifest for a user? |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
this sample should run and trigger download file in your browser |
Oh, and it's not used by anything else right now? Or I guess not by 7.0 users, thus not backporting? |
/azp run runtime,runtime-staging |
Azure Pipelines successfully started running 2 pipeline(s). |
Thanks for asking @radical , I did bit more research. So, the method had different name in Net7 it was I changed it in #77779 and broken it without noticing it (which is Net8). We should eventually add some WBT+playwrite to cover more samples or more scenarios. |
The error is unrelated |
This is also wrong on Net7 but this code path via cwraps was not used and it worked via
ccall
.We don't need to backport it.