Avoid bloom filter checks for IndexOfAnyExcept in ProbabilisticMap #85203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of
ProbabilisticMap
is to avoid doing expensivevalues.Contains(char)
checks for every input character by applying a bloom filter first. This works well forIndexOfAny
, but withIndexOfAnyExcept
we still have to check each character since we don't have an "inverse bloom filter".For an input value that isn't in the set, the bloom filter will save us from doing the verification step, but that will by definition happen only once per
IndexOfAnyExcept
call. The overhead of checking it for all the characters that are in the set is wasted.This PR avoids doing those bloom filter checks for
IndexOfAnyExcept
paths.In practice
IndexOfAnyExcept
inIndexOfAnyCharValuesProbabilistic
now isn't doing anything interesting with theProbabilisticMap
, but that's just a convenient place to share some of the logic thatProbabilisticMap
needs anyway.