Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResolvePackageDependencies is producing 6.5% of allocations in a build #1711

Closed
davkean opened this issue Nov 2, 2017 · 6 comments
Closed

Comments

@davkean
Copy link
Member

davkean commented Nov 2, 2017

In a customer solution I'm looking at, I see that ResolvePackageDependencies is producing 6.5% of all allocations for an up-to-date build:

image

Can we see if we can trim/remove unneeded allocations from this task.

@nguerrera
Copy link
Contributor

Working on this.

@davkean
Copy link
Member Author

davkean commented Dec 6, 2017

👍

@nguerrera
Copy link
Contributor

nguerrera commented Mar 5, 2018

#2020 should bring this down to a bare minimum for the incremental (normal) build case. We now deserialize into ITaskItem[] with near zero waste when project.assets.json has not changed. However, I'm leaving this open after that goes in because we still use the old ResolvePackageDependencies for the dependencies node in the IDE. I will be working with project system folks to get that fixed next.

@nguerrera
Copy link
Contributor

cc @abpiskunov @Pilchie

@nguerrera
Copy link
Contributor

Fixed by #2020. Will use a separate issue for design-time build case.

@nguerrera
Copy link
Contributor

#2100 tracks design-time build case now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants