Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blazor][net7] dotnet..js file name is missing version info #30802

Closed
pavelsavara opened this issue Feb 23, 2023 · 10 comments
Closed

[blazor][net7] dotnet..js file name is missing version info #30802

pavelsavara opened this issue Feb 23, 2023 · 10 comments
Assignees
Labels
arch-wasm Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Milestone

Comments

@pavelsavara
Copy link
Member

pavelsavara commented Feb 23, 2023

Actual behavior

The file name of dotnet..8wdpaewqyh.js generated by blazor app is missing version info.

image

Expected behavior

dotnet.7.0.3.pe05f8nz0f.js

To Reproduce

  • SDK 7.0.103
  • install wasm-tools 7.0.3
  • create simpla blazor wasm app from template
  • add <WasmBuildNative>true</WasmBuildNative> to client project file
  • dotnet run -bl -c Release

Notes

DotNetJsVersion is used to build the name in _ResolveBlazorWasmOutputs, but it is set much later in the ProcessPublishFilesForBlazor

@pavelsavara pavelsavara added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch arch-wasm labels Feb 23, 2023
@pavelsavara pavelsavara added this to the 7.0.3xx milestone Feb 23, 2023
@pavelsavara
Copy link
Member Author

@pavelsavara pavelsavara changed the title [blazor] dotnet..js app is missing version info [blazor] dotnet..js file name is missing version info Feb 23, 2023
@marcpopMSFT marcpopMSFT added the untriaged Request triage from a team member label Mar 8, 2023
@javiercn
Copy link
Member

@pavelsavara is this a "build" only thing? Does the published version get the right version in it?

@mkArtakMSFT
Copy link
Member

mkArtakMSFT commented Apr 19, 2023

Ping @pavelsavara
We're trying to understand if something is broken and has to be addressed in a patch in .NET 7 or not.

@pavelsavara
Copy link
Member Author

It doesn't reproduce for you ?

@marcpopMSFT marcpopMSFT modified the milestones: 7.0.3xx, 7.0.4xx Apr 19, 2023
@pavelsavara
Copy link
Member Author

I tested again with 7.0.400-preview.23224.17 and wasm-tools 7.0.5/7.0.100 (SDK 7.0.400-preview.23224).

dotnet run -c Release will indeed produce wrong file name dotnet..o2qge3ran4.js.

image

image

It works well with publish
image

@lewing
Copy link
Member

lewing commented Apr 26, 2023

is this with an 8.0.1xx sdk?

@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 26, 2023

no, this is Net7, I have not tried net8

@pavelsavara pavelsavara changed the title [blazor] dotnet..js file name is missing version info [blazor][net7] dotnet..js file name is missing version info Apr 26, 2023
@javiercn
Copy link
Member

@pavelsavara is the app functional and the js file contains the wrong name or is it functional?

@pavelsavara
Copy link
Member Author

it's just bad file name but the app works fine

@maraf
Copy link
Member

maraf commented May 10, 2023

It is caused by native relink on build, not publish.
The SDK bits have moved to Wasm SDK, we will fix it there and backport to .NET 7 SDK here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

6 participants