Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable interceptors feature when ConfigurationBindingGenerator is enabled #35045

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Enable interceptors feature when ConfigurationBindingGenerator is enabled #35045

merged 1 commit into from
Aug 30, 2023

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Aug 30, 2023 •
edited
Loading

Porting #34840 to RC-2. Ideally should be merged to RC-2 before #35024, so that git history shows the right progression of the feature & to include the unit test for config binding.

@layomia layomia added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Aug 30, 2023
@layomia layomia self-assigned this Aug 30, 2023
@layomia layomia requested a review from vijayrkn as a code owner August 30, 2023 16:44
@layomia layomia added this to the 8.0.1xx milestone Aug 30, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Aug 30, 2023
@ghost
Copy link

ghost commented Aug 30, 2023

Thanks for your PR, @layomia.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

jeffhandley
jeffhandley approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I defer to @marcpopMSFT on merging into this repo.

@baronfel
Copy link
Member

Merging to get into rc2 and onwards.

@baronfel baronfel merged commit 3f48227 into dotnet:release/8.0.1xx Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffhandley jeffhandley jeffhandley approved these changes

@captainsafia captainsafia captainsafia approved these changes

@eerhardt eerhardt eerhardt approved these changes

@tarekgh tarekgh tarekgh approved these changes

@marcpopMSFT marcpopMSFT Awaiting requested review from marcpopMSFT

@vijayrkn vijayrkn Awaiting requested review from vijayrkn vijayrkn is a code owner

Assignees

@layomia layomia

Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Milestone
8.0.1xx
Development

Successfully merging this pull request may close these issues.
6 participants
@layomia @baronfel @jeffhandley @captainsafia @eerhardt @tarekgh