Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respond to sourcelink being bundled in the SDK #3439

Closed
MichaelSimons opened this issue May 11, 2023 · 2 comments
Closed

Respond to sourcelink being bundled in the SDK #3439

MichaelSimons opened this issue May 11, 2023 · 2 comments
Assignees
@NikolaMilosavljevic
Labels
area-additional-repos Adding additional contributing repos

Comments

@MichaelSimons
Copy link
Member

SourceLink is now be bundled in with the SDK - dotnet/sdk#31632. This has an impact on source-build that needs to be reacted to. SourceLink will no longer be required to be build as one of the source-build toolset repos. The SourceLink used by the build will now come from the SDK used to build the product. The sourcelink repo can now be treated as a normal product repo which the SDK has a dependency on.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-additional-repos Adding additional contributing repos untriaged labels May 11, 2023
@MichaelSimons MichaelSimons moved this to 8.0 Preview 5 in .NET Source Build May 12, 2023
@MichaelSimons
Copy link
Member Author

[Triage] This work will be blocked on the cleanup work to remove the sourcelink version.details dependencies from the product repos.

@MichaelSimons MichaelSimons moved this from 8.0 Preview 5 to 8.0 Backlog in .NET Source Build May 18, 2023
@MichaelSimons MichaelSimons moved this from Needs Review to 8.0 Backlog in .NET Source Build Jun 8, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Backlog to 8.0 Preview 7 in .NET Source Build Jun 22, 2023
This was referenced Jul 10, 2023
Merged
Closed
@MichaelSimons MichaelSimons moved this from 8.0 Preview 7 to In Progress in .NET Source Build Jul 11, 2023
@MichaelSimons
Copy link
Member Author

Closing as completed. #3551 tracks cleaning up the sourcelink dependencies.

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-additional-repos Adding additional contributing repos
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelSimons @NikolaMilosavljevic