Regression - #12663 broke StatusStrip DarkMode coloring.

[KlausLoeffelmann]

.NET version

Hey @LeafShi1, @Olina-Zhang

Can you please make sure, if this change #12663 did not break the DarkMode Coloring (not HighContrast! I mean DarkMode.) in .NET 9?

Thanks.

Also @merriemcgaw, @Tanya-Solyanik FYI.

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

As in Description.

Steps to reproduce

As in Description.

[JeremyKuhne]

@KlausLoeffelmann can you please give details / links on how to validate?

[Olina-Zhang]

@KlausLoeffelmann @JeremyKuhne Here is current testing result for both of .NET 9.0 and .NET 10.0. Because the change #12663 is not ported to .NET 9.0, so the #12663 still reproduces in .NET 9.0, fixed in .NET 10.0. For DarkMode, runtime is in DarkMode, no affect.

.NET 10.0:

.NET 9.0.2:

[Olina-Zhang]

But for StatusStrip, now renderMode was changed to System(#12719), so have DarkMode issue for both of .NET 9.0 and .NET 10.0, we have a known issue: #11901

[KlausLoeffelmann]

Yeah, and that's an issue. We cannot have System for DarkMode.
What was the reason for changing it?

[merriemcgaw]

@LeafShi1 , @Epica3055 it looks like #12663 broke DarkMode with the fix. We should either revert the accessibility change or find a way to account for Dark Mode in the fix so that we're not changing the rendering when explicitly in Dark Mode.

@Olina-Zhang I think we will need to start doing a sanity pass over Dark Mode with each Preview test pass.

Everyone, if we touch anything to do with colors we should definitely make sure that we are accounting for the possibility of DarkMode being enabled in the project for .NET 9+ fixes.

[Tanya-Solyanik]

@KlausLoeffelmann

Yeah, and that's an issue. We cannot have System for DarkMode. What was the reason for changing it?

The reason was compatibility if the default sizes with .NET Framework - https://referencesource.microsoft.com/#System.Windows.Forms/winforms/Managed/System/WinForms/[StatusStrip.cs](https://referencesource.microsoft.com/#System.Windows.Forms/winforms/Managed/System/WinForms/StatusStrip.cs,47),47,
To support DarkMode, devs would have to use not a System renderer.

I don't think we should change the default renderer again

[merriemcgaw]

@Olina-Zhang does this happen with both System and Professional renderers?

@KlausLoeffelmann - let's make sure we have explicit docs about what happens with DarkMode + System and DarkMode + Professional and have a formal call here before we make a change here.

[KlausLoeffelmann]

I cannot remember the technical issues we had back in the day when we investigated. It was something with the system color, if I remember correctly, which could not be overridden - but for once, I am not 100% sure if that was it, and secondly, since we changed the .NET runtime, it might be possible now.

I need to take a look then, later next week. But if this fix gets serviced, we should also service then the fix for the fix, because dark mode right now is broken. Fix for 9 should go out then with the Analyzers ideally, and we can aim Preview 3 for the Dark Mode fix(es).

[Olina-Zhang]

@Olina-Zhang does this happen with both System and Professional renderers?

No, just happens in System RenderMode.

[Progress1]

I can confirm. It's only on System render (Professional, ManagerRenderMode works)

[Tanya-Solyanik]

@KlausLoeffelmann - System renderer had never worked with the Dark mode, this is not really a regression. Customers can change the renderer for StatusStrip as needed. This should not be Priority 1