Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12916 Cannot use down to expand ToolStripDropDownButton in toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1 #13034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Feb 26, 2025

Fixes #12916

Root cause

When we use Tab key to focus on second ToolStrip and then press down key, ProcessCmdKey method get triggered, but the event owner isn't right, it should have been toolStrip2 not toolStrip1.
image

Proposed changes

  • Set Active ToolStrip when ToolStrip get focused.

Screenshots

Before

Image

Image

After

12916_02

Test methodology

  • manually
Microsoft Reviewers: Open in CodeFlow

… toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1
@Epica3055 Epica3055 requested a review from a team as a code owner February 26, 2025 08:55
@Epica3055 Epica3055 requested a review from Copilot February 26, 2025 08:55

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.09527%. Comparing base (ff19802) to head (ef980e9).
Report is 108 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13034         +/-   ##
===================================================
- Coverage   76.13911%   76.09527%   -0.04385%     
===================================================
  Files           3258        3272         +14     
  Lines         642851      643701        +850     
  Branches       47307       47438        +131     
===================================================
+ Hits          489461      489826        +365     
- Misses        149825      150314        +489     
+ Partials        3565        3561          -4     
Flag Coverage Δ
Debug 76.09527% <100.00000%> (-0.04385%) ⬇️
integration 18.04832% <100.00000%> (-0.12485%) ⬇️
production 50.11025% <100.00000%> (+0.02727%) ⬆️
test 96.95227% <ø> (-0.01762%) ⬇️
unit 47.54096% <100.00000%> (+0.11339%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Feb 26, 2025
@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Feb 26, 2025
@Epica3055 Epica3055 added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s)
Projects
None yet
4 participants