Enable nullable reference types for System.Windows.Forms.Design
#8343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
elachlan
changed the title
System.Windows.Forms.Design
|
CC: @gpetrou |
RussKie
reviewed
Dec 7, 2022
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/LockedBorderGlyph.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Dec 7, 2022
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/LockedHandleGlyph.cs
Outdated
Show resolved
Hide resolved
dreddy-work
previously approved these changes
Dec 7, 2022
|
@elachlan , can you rebase this and resolve conflicts? |
dreddy-work
added
the
ready-to-merge
auto-merge was automatically disabled
December 7, 2022 21:31
Head branch was pushed to by a user without write access
done. |
dreddy-work
previously approved these changes
Dec 7, 2022
|
src\System.Windows.Forms.Design\src\System\ComponentModel\Design\DesignerActionUI.cs(7,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. and similar. Please build locally and it should report there too. |
auto-merge was automatically disabled
December 7, 2022 22:11
Head branch was pushed to by a user without write access
Fixed. |
lonitra
approved these changes
Dec 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR enables nullability at the project level and sets the nullable annotation context to disabled where the code does not compile without warnings.
#nullable disableannotation.#nullable enableannotation.Related: #8342, #1107
Microsoft Reviewers: Open in CodeFlow