Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullability in DesignSurface related code #9192

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

halgab
Copy link
Contributor

@halgab halgab commented May 28, 2023

Contributes to #8342

Proposed changes

  • Enable nullability in DesignSurface, DesignSurfaceCollection, DesignSurfaceEventArgs, DesignSurfaceEventHandler, DesignSurfaceManager, DesignSurfaceServiceContainer, ReferenceService, DesignerEventService and ActiveDesignSurfaceChangedEventArgs
Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned halgab May 28, 2023
@ghost ghost added the area-NRT label May 28, 2023
@ghost ghost added the draft draft PR label May 28, 2023
@halgab halgab marked this pull request as ready for review May 28, 2023 21:06
@halgab halgab requested a review from a team as a code owner May 28, 2023 21:06
}

_fullName = string.Empty;
_fullName ??= string.Empty;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked odd, so I checked and it looked like a bug introduced in #7921

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!.

@dreddy-work dreddy-work enabled auto-merge (squash) June 21, 2023 19:57
@dreddy-work dreddy-work added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jun 21, 2023
@dreddy-work dreddy-work disabled auto-merge June 21, 2023 21:28
@dreddy-work dreddy-work merged commit 0f2ae6b into dotnet:main Jun 21, 2023
@ghost ghost added this to the 8.0 Preview6 milestone Jun 21, 2023
@ghost ghost removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jun 21, 2023
@halgab halgab deleted the design-surface-null branch June 22, 2023 09:23
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants