Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullability in TypeCodeDomSerializer #9529

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Enable nullability in TypeCodeDomSerializer #9529

merged 4 commits into from
Oct 19, 2023

Conversation

halgab
Copy link
Contributor

@halgab halgab commented Jul 20, 2023 •
edited by ghost
Loading

Another follow-up to #9099

Proposed changes

  • Enable nullability in TypeCodeDomSerializer
  • Enable nullability in CodeDomSerializationProvider
  • Enable nullability in ComponentTypeCodeDomSerializer
Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned halgab Jul 20, 2023
@ghost ghost added the area-NRT label Jul 20, 2023
@halgab halgab force-pushed the TypeCodeDomSerializer_null branch from 15f7e70 to e30c929 Compare July 20, 2023 14:15
@ghost ghost added the draft draft PR label Jul 20, 2023
@halgab halgab force-pushed the TypeCodeDomSerializer_null branch 2 times, most recently from 8ba450b to 7ce195d Compare July 21, 2023 20:46
@halgab halgab marked this pull request as ready for review July 22, 2023 10:46
@halgab halgab requested a review from a team as a code owner July 22, 2023 10:46
@ghost ghost removed the draft draft PR label Jul 22, 2023
dreddy-work
dreddy-work reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more than nullability changes. Please rebase to .NET9.0-Test branch and we will be merging it there.

@dreddy-work dreddy-work added Net9.0 waiting-author-feedback The team requires more information from the author labels Jul 24, 2023
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Jul 24, 2023
@halgab halgab changed the base branch from main to Net9.0-Test July 24, 2023 19:38
@halgab halgab force-pushed the TypeCodeDomSerializer_null branch 2 times, most recently from ca2541d to ede99ab Compare July 24, 2023 19:45
@dreddy-work dreddy-work changed the base branch from Net9.0-Test to feature/9.0 July 25, 2023 19:07
@halgab halgab force-pushed the TypeCodeDomSerializer_null branch from ede99ab to a73df4a Compare August 2, 2023 21:09
@halgab
Copy link
Contributor Author

halgab commented Sep 13, 2023

Should I rebase this PR back to main?

@halgab halgab requested a review from dreddy-work September 13, 2023 13:25
@halgab halgab changed the base branch from feature/9.0 to main September 30, 2023 12:04
@halgab halgab force-pushed the TypeCodeDomSerializer_null branch from a73df4a to dc15a69 Compare September 30, 2023 12:04
@halgab
Copy link
Contributor Author

halgab commented Sep 30, 2023

Should I rebase this PR back to main?

I just did that, considering feature/9.0 seems to be stale @dreddy-work

@halgab halgab force-pushed the TypeCodeDomSerializer_null branch from 63176c1 to b5ced21 Compare October 6, 2023 08:43
@halgab
Copy link
Contributor Author

halgab commented Oct 18, 2023

This one has been ready for a while @lonitra

lonitra
lonitra approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 18, 2023
@lonitra lonitra merged commit ff335d4 into dotnet:main Oct 19, 2023
@ghost ghost added this to the 9.0 Preview1 milestone Oct 19, 2023
@ghost ghost removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 19, 2023
@halgab halgab deleted the TypeCodeDomSerializer_null branch October 20, 2023 05:06
@halgab halgab mentioned this pull request Oct 20, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonitra lonitra lonitra approved these changes

@dreddy-work dreddy-work Awaiting requested review from dreddy-work

Assignees

@halgab halgab

Labels
area-NRT
Projects
None yet
Milestone
9.0 Preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@halgab @lonitra @dreddy-work