Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): fix some performance issue #4664

Merged
merged 1 commit into from
Feb 17, 2025
Merged

fix(sheet): fix some performance issue #4664

merged 1 commit into from
Feb 17, 2025

Conversation

VicKun4937
Copy link
Contributor

  • performance some

Copy link

github-actions bot commented Feb 17, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 34 seconds
commit  71c4cc1
info  For more information, see full report

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 32.68%. Comparing base (f39baf5) to head (71c4cc1).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/shared/generate.ts 0.00% 9 Missing ⚠️
...sheets-ui/src/controllers/status-bar.controller.ts 0.00% 5 Missing ⚠️
packages/core/src/common/boolean.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4664      +/-   ##
==========================================
- Coverage   32.70%   32.68%   -0.02%     
==========================================
  Files        2605     2605              
  Lines      135611   135620       +9     
  Branches    30165    30167       +2     
==========================================
- Hits        44349    44327      -22     
- Misses      91262    91293      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit b9e7402 into dev Feb 17, 2025
9 checks passed
@wzhudev wzhudev deleted the fix-performance-issue branch February 17, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants