Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paste rich text with br should keep line break #4670

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Feb 18, 2025

close #4454

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested a review from yuhongz as a code owner February 18, 2025 12:39
Copy link

github-actions bot commented Feb 18, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 18, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 33 seconds
commit  6984d9f
info  For more information, see full report

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.66%. Comparing base (95f6b9d) to head (6984d9f).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...ui/src/services/clipboard/html-to-usm/converter.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4670      +/-   ##
==========================================
+ Coverage   32.64%   32.66%   +0.01%     
==========================================
  Files        2606     2606              
  Lines      135670   135675       +5     
  Branches    30204    30206       +2     
==========================================
+ Hits        44296    44318      +22     
+ Misses      91374    91357      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 20, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Feb 20, 2025
@ybzky ybzky force-pushed the fix-paste-rich-text branch from 6c69a30 to 6984d9f Compare February 20, 2025 12:55
@ybzky ybzky merged commit 535a2a9 into dev Feb 21, 2025
9 checks passed
@ybzky ybzky deleted the fix-paste-rich-text branch February 21, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Line Breaks Disappear When Pasting Multiple Cells into Univer Sheet
4 participants