Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-formula-ui): edit other sheet range error #4673

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Feb 19, 2025

close https://github.com/dream-num/univer-pro/issues/4004

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Feb 19, 2025
Copy link

github-actions bot commented Feb 19, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 19, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 30 seconds
commit  d6934f8
info  For more information, see full report

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Project coverage is 32.66%. Comparing base (4b38dc6) to head (d6934f8).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...iews/formula-editor/hooks/use-formula-selection.ts 0.00% 49 Missing ⚠️
...formula-editor/hooks/use-sheet-selection-change.ts 0.00% 9 Missing ⚠️
...s/range-selector/hooks/use-left-and-right-arrow.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4673   +/-   ##
=======================================
  Coverage   32.65%   32.66%           
=======================================
  Files        2605     2605           
  Lines      135611   135643   +32     
  Branches    30182    30197   +15     
=======================================
+ Hits        44286    44307   +21     
- Misses      91325    91336   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 20, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Feb 20, 2025
@weird94 weird94 merged commit dec0fdb into dev Feb 20, 2025
9 checks passed
@weird94 weird94 deleted the fix/edit-other-sheet-ref-range branch February 20, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants