Disable numbered access to positional args on tuples #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error[E0381]: used binding `ahead` is possibly-uninitialized
--> impl/src/fmt.rs:187:30
|
182 | let ahead;
| ----- binding declared here but left uninitialized
183 | if *syn_full.get_or_insert_with(is_syn_full) && {
184 | ahead = input.fork();
| -----
| |
| binding initialized here in some conditions
| binding initialized here in some conditions
...
187 | input.advance_to(&ahead);
| ^^^^^^ `ahead` used here but it is possibly-uninitialized
roypat
added a commit
to firecracker-microvm/firecracker
that referenced
this pull request
Nov 12, 2024
See dtolnay/thiserror#354 Signed-off-by: Patrick Roy <[email protected]>
roypat
added a commit
to firecracker-microvm/firecracker
that referenced
this pull request
Nov 12, 2024
See dtolnay/thiserror#354 Signed-off-by: Patrick Roy <[email protected]>
bors-ferrocene bot
added a commit
to ferrocene/criticalup
that referenced
this pull request
Nov 14, 2024
64: Maintenance updates r=Hoverbear a=amanjeev
- Updates dependencies for crates
- Notably: `thiserror` to `2.0.3` from `1`.
- Major breaking change for CriticlaUp was:
> Tuple structs and tuple variants can no longer use numerical {0} {1} access at the same time as supplying extra positional arguments for a format message, as this makes it ambiguous whether the number refers to a tuple field vs a different positional arg (dtolnay/thiserror#354)
- Removes some unused deps.
Co-authored-by: Amanjeev Sethi <[email protected]>
kanpov
pushed a commit
to kanpov/firecracker
that referenced
this pull request
Nov 20, 2024
See dtolnay/thiserror#354 Signed-off-by: Patrick Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.