Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide main for brotli and non-brotli builds #1378

Closed
wants to merge 1 commit into from
Closed

provide main for brotli and non-brotli builds #1378

wants to merge 1 commit into from

Conversation

withinboredom
Copy link
Collaborator

Provides a brotli and non-brotli main file for caddy.

fixes #1377

@dunglas
Copy link
Owner

dunglas commented Feb 16, 2025

I don't think it's necessary.

The main.go file is just there for convenience for "internal" (or at least "standard" builds: they allow to be sure of the exact dependencies used.

Users should use xcaddy for custom builds with custom modules or dependencies. xcaddy will generate the appropriate main.go file.

@withinboredom
Copy link
Collaborator Author

Makes sense!

@withinboredom withinboredom deleted the main-no-br branch February 16, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag nobrotli doesn't properly work
2 participants
@withinboredom @dunglas