Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover feedback is not working when using the EdgeCreationTool #1471

Open
tortmayr opened this issue Feb 3, 2025 · 0 comments
Open

Hover feedback is not working when using the EdgeCreationTool #1471

tortmayr opened this issue Feb 3, 2025 · 0 comments
Labels
bug Something isn't working client

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Feb 3, 2025

When the EdgeCreationTool is active, hover feedback does not work.
This is caused by the the check in this GLSPHoverMouseListener:
https://github.com/eclipse-glsp/glsp-client/blob/2d240a399693676cd7ac2b3740f95f4b6562f3ad/packages/client/src/features/hover/hover.ts#L58

Affectingly the hover listener is completely disabled when the EdgeCreationTool is active. I think the intention behind this was to avoid hover popup computation during edge creation. While we definitely should do that, the hover Feedback should still be active (or at least it should be configurable).
The hover feedback provides a nice visual indicator about the current target/source candidate.

In addition, we should find a cleaner solution instead of hardcoding the disablement into the GLSPHoverTool. This creates an indirect dependency between the hoverModule and the edgeCreationModule.

@tortmayr tortmayr added bug Something isn't working client labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client
Projects
None yet
Development

No branches or pull requests

1 participant