Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish scripts only update changed packages #14954

Open
tsmaeder opened this issue Feb 18, 2025 · 3 comments
Open

Publish scripts only update changed packages #14954

tsmaeder opened this issue Feb 18, 2025 · 3 comments

Comments

@tsmaeder
Copy link
Contributor

Bug Description:

While doing a patch release following the instructions, I ended only publishing the packages which had changes since the last publish. This seems consistent with the lerna doc, since we're not passing --force-publish to lerna in the package scripts.

Steps to Reproduce:

  1. Follow the publishing instruction, I used npm run publish:latest to publish theia
  2. Observe: you end up with only a couple of published packages
  3. Observe: lerna reports it published 76 packages, which is not true 🤷

Additional Information

  • Operating System: Ubuntu 22.04
  • Theia Version: 1.58.x
@tsmaeder
Copy link
Contributor Author

I propose that instead of doing an immediate lerna publish we do a lerna version first. We can then compare the outcome to our expectations and then either lerna publish --fromPackage (or whatever the right flag is) or reset the changes via git and try again.
In the long run, publishing should be done via a github workflow, IMO.

@sgraband
Copy link
Contributor

Another idea would be to do something similar to what the Theia IDE does: script.

@tsmaeder
Copy link
Contributor Author

Additional info: I don't think a missing --force-publish parameter is the issue: we configure this in lerna.json and when I observe the lerna publish run, it first creates ~80 changes (as seen with git status and after the publish, some of these changes seem to be reverted. Is it my machine? Is this a spurious problem? Needs to be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants