Unreachable Code in tab-bars.ts

[tsmaeder]

Bug Description:

In tab-bars.ts#1233 there is unreachable code. The line reads:

 if ((newOverflowingTabs.length !== this.tabsOverflowData?.titles.length ?? 0) ||...

But probably should read

 if ((newOverflowingTabs.length !== (this.tabsOverflowData?.titles.length ?? 0)) ||...

I'm not recently familiar with the code, so not sure what the right fix is or whether this causes problems.

Additional Information

• Operating System:
• Theia Version:

[tsmaeder]

@tortmayr do you know immediately what the right fix is?

[tortmayr]

Since there already is a null-check for this.tabOverflowData in tab-bars.ts#1226
the right fix is probably just:

         if ((newOverflowingTabs.length !== this.tabsOverflowData.titles.length) || ...

[tsmaeder]

But that's not equivalent in the case where `newOverflowingTabs.length is 0 and this.tabsOverflowData is undefined.

[tortmayr]

It is, since we never reach this part of the code if this.tabOverflowData is undefined anyways.
In this case we return early in tab-bars.ts#1229

theia/packages/core/src/browser/shell/tab-bars.ts

Line 1229 in 3435376

return;