feat: allocate rx buffer #1768
feat: allocate rx buffer #1768
Conversation
|
PR missing one of the required labels: {'documentation', 'internal', 'dependencies', 'breaking-change', 'new feature', 'bug', 'enhancement'} |
wyfo
force-pushed
the
feat/read_buffer_allocation
branch
from
6790979 to
15f661e
Compare
| /// For very high throughput scenarios, the rx_buffer_size can be increased to accommodate | ||
| /// more in-flight data. This is particularly relevant when dealing with large messages. | ||
| /// E.g. for 16MiB rx_buffer_size set the value to: 16777216. | ||
| buffer_size: 65535, |
There was a problem hiding this comment.
Should we keep the config and mark it not available instead of removing it?
I'm not sure how much we want to maintain compatibility.
There was a problem hiding this comment.
Don't know honestly. But this config is misleading, it's not a question of buffer size but of a number of batches, and the only case where more than one batch will be used is when a payload is cloned in a subscriber (e.g. a channel subscriber), so it's not the case for router for example.
So user may be tempted to increase the "buffer size" for a router with big traffic, but it will just allocate more unused memory.
No description provided.