Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve smiles #20

Merged
merged 5 commits into from
Mar 24, 2023
Merged

Improve smiles #20

merged 5 commits into from
Mar 24, 2023

Conversation

Aggrathon
Copy link
Member

Add a column selector to the smiles plot. The list of columns is filtered to only show columns with strings. If there is a column with "smiles" in the name (case insensitive) it is selected as the default (so it works just like before).

@Aggrathon Aggrathon requested a review from TanakaAkihiro March 23, 2023 15:50
Copy link
Collaborator

@TanakaAkihiro TanakaAkihiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aggrathon Aggrathon merged commit 039fdd3 into main Mar 24, 2023
@Aggrathon Aggrathon deleted the improve-smiles branch March 24, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants