Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug: download embedding columns #23

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Debug: download embedding columns #23

merged 3 commits into from
Apr 6, 2023

Conversation

TanakaAkihiro
Copy link
Collaborator

No description provided.

@TanakaAkihiro TanakaAkihiro requested a review from juntyr March 27, 2023 15:35
@juntyr
Copy link
Collaborator

juntyr commented Mar 28, 2023

Unfortunately this does not yet solve the issue with re-uploading data+plots where a plot depends on xiplot-generated PCA embeddings

juntyr
juntyr requested changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug still persists - perhaps look at how the clusters are saved during downloading and adapt that for the extra embedding columns

@TanakaAkihiro
Copy link
Collaborator Author

Hope that this time the fix works :)

@juntyr

@juntyr juntyr self-requested a review April 5, 2023 08:51
juntyr
juntyr approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juntyr juntyr requested a review from Aggrathon April 5, 2023 08:51
@juntyr juntyr mentioned this pull request Apr 5, 2023
Closed
@Aggrathon
Copy link
Member

Storing the PCA data as strings instead of numbers is a bit strange

@TanakaAkihiro
Copy link
Collaborator Author

It seems like cluster data is also stored as strings... I'll merge this one and we could fix it later, if it's fine

@TanakaAkihiro TanakaAkihiro merged commit b1d5584 into main Apr 6, 2023
@juntyr juntyr deleted the Embedding-debug branch April 10, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juntyr juntyr juntyr approved these changes

@Aggrathon Aggrathon Awaiting requested review from Aggrathon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TanakaAkihiro @juntyr @Aggrathon