Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flask dependency from pyproject.toml #32

Merged
merged 5 commits into from
May 5, 2023
Merged

Conversation

Aggrathon
Copy link
Member

@Aggrathon Aggrathon commented May 2, 2023

This is related to the discussion in #30, where we noticed that unnecessarily requiring a specific version of indirect dependencies can cause trouble when installing xiplot.

@Aggrathon Aggrathon marked this pull request as ready for review May 2, 2023 14:18
@Aggrathon
Copy link
Member Author

This also fixes the dependabot security alert

@Aggrathon Aggrathon requested a review from TanakaAkihiro May 2, 2023 14:27
@Aggrathon
Copy link
Member Author

I also updated the GitHub action for testing and noticed that we now can test on Python 3.11 and do not need to force an old flask version (so that takes care of the other dependabot alert).

Copy link
Collaborator

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@TanakaAkihiro TanakaAkihiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aggrathon Aggrathon merged commit 5b6a040 into main May 5, 2023
@Aggrathon Aggrathon deleted the slim-dependencies branch May 5, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants