Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Mono Not Working In Visual Studio Code #70

Closed
davgar99 opened this issue Nov 17, 2023 · 10 comments
Closed

Commit Mono Not Working In Visual Studio Code #70

davgar99 opened this issue Nov 17, 2023 · 10 comments
Labels
Bug Something isn't working

Comments

@davgar99
Copy link

davgar99 commented Nov 17, 2023

Font is not being detected by Visual Studio Code. What I mean by that is that whenever I change the font to Commit Mono, the font does not change.
Steps I took:

  1. Installed the latest default font under releases.
  2. Restarted Visual Studio Code.
  3. Restarted my computer.
  4. Uninstalled and reinstalled font and tried both OTF and TTF formats.
  5. Issue remains unresolved.
2023-11-17.07-47-11.mp4
@eigilnikolajsen
Copy link
Owner

eigilnikolajsen commented Nov 17, 2023

Try one of the following, to see if it resolves the problem:

  1. Add quotes to the font name like 'CommitMono'
  2. Add these lines to the user settings JSON
"editor.fontFamily": "CommitMono",
"editor.fontLigatures": true,

Tell me if that works. Or else there might be some other issue causing this.

@eigilnikolajsen eigilnikolajsen added the Issue Something to look into label Nov 17, 2023
@davgar99
Copy link
Author

I did as you said and it didn't work, but weirdly enough I did manage to fix it by downloading version 1.139.
Versions 1.140 and 1.141 don't seem to work on VS Code.
On a side note, I'm running Windows 11 Pro 23H2.

@davgar99 davgar99 changed the title Commit Mono Not Working On Visual Studio Code Commit Mono Not Working In Visual Studio Code Nov 17, 2023
@eigilnikolajsen
Copy link
Owner

Many thanks. I will fix this first priority. I might need some help testing when done.

@eigilnikolajsen eigilnikolajsen added Bug Something isn't working and removed Issue Something to look into labels Nov 17, 2023
@davgar99
Copy link
Author

I'll be able to test it out for you unless you want to create a testing branch for testing purposes.
Let me know 😄

@plttn
Copy link

plttn commented Nov 18, 2023

I can replicate this on my Windows machine as well.

It looks like an issue with the font family metadata? If I open Control Panel and navigate to fonts, only one of the 4 versions shows up, rather than showing as a font family.

image

If I delete the 700 bold italic showing here, 700 bold appears to replace it, and repeating until I've deleted all 4 files.

@eigilnikolajsen
Copy link
Owner

I have located the source of the issue and fixed it. If you download the font from the website it should be fixed. I will update the release on Monday, can't right now.

@plttn
Copy link

plttn commented Nov 18, 2023

Looks like that mostly worked.

The family is now working as expected in VSCode, however the only two faces in the family as shown are now 400-regular and 700-italic so I would suspect that any regular italic or unitalicized bold would not show up properly:

image

@eigilnikolajsen
Copy link
Owner

eigilnikolajsen commented Nov 18, 2023

Honestly I don't know about Windows and fonts at this point. I get only the italics in the folder, but when I go to font settings in settings all 4 show up. Even though only the italics are showing up in my folder, the regular and bold still works in VS code. I've checked the naming multiple times but all seems to be identical between the 4 styles. If you have any tips, throw them my way, please.

Additionally, @vagreargnatry from #68 gets only italic and bold in his folder, so it seems like a gamble what styles show up haha.

image image

@plttn
Copy link

plttn commented Nov 18, 2023

Ah yep, my bad, looks like it is actually showing in font settings.

@eigilnikolajsen
Copy link
Owner

I am closing this since it is resolved with release v1.142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants