Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Add namespace to helm test command in NOTES.txt #1105

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

mrtzgh
Copy link
Contributor

@mrtzgh mrtzgh commented Mar 15, 2021

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Helm chart NOTES.txt was missing namespace in the test section:
before change:

LAST DEPLOYED: Mon Mar 15 21:24:35 2021
NAMESPACE: elk
STATUS: deployed
REVISION: 1
NOTES:
1. Watch all cluster members come up.
  $ kubectl get pods --namespace=elk -l app=elasticsearch-master -w
2. Test cluster health using Helm test.
  $ helm test elasticsearch

after change:

NAMESPACE: elk
STATUS: deployed
REVISION: 1
NOTES:
1. Watch all cluster members come up.
  $ kubectl get pods --namespace=elk -l app=elasticsearch-master -w
2. Test cluster health using Helm test.
  $ helm --namespace=elk test elasticsearch

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@mrtzgh mrtzgh marked this pull request as ready for review March 15, 2021 19:04
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Member

jmlrt commented Mar 17, 2021

jenkins test this please

@jmlrt jmlrt added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Mar 17, 2021
@jmlrt jmlrt merged commit 4524945 into elastic:master Mar 17, 2021
@jmlrt jmlrt added the backport label Mar 17, 2021
jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Sep 22, 2021
jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Sep 22, 2021
jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Sep 22, 2021
jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Sep 22, 2021
jmlrt added a commit that referenced this pull request Sep 22, 2021
jmlrt added a commit that referenced this pull request Sep 22, 2021
jmlrt added a commit that referenced this pull request Sep 22, 2021
jmlrt added a commit that referenced this pull request Sep 22, 2021
This was referenced Dec 14, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants