This repository has been archived by the owner on May 16, 2023. It is now read-only.

[all] Add support to ingress networking.k8s.io/v1 & ingressClassName #1409

Merged

jmlrt merged 14 commits into elastic:main from framsouza:master

Oct 14, 2021

Contributor

framsouza commented Oct 11, 2021 •

edited by jmlrt

Loading

This PR adds support to ingress networking.k8s.io/v1 that was added in Kubernetes v1.19.

Fix #1381
Fix #1136

cla-checker-service bot commented Oct 11, 2021 •

edited

Loading

💚 CLA has been signed

framsouza closed this

framsouza reopened this

framsouza closed this

framsouza reopened this

framsouza force-pushed the master branch from 0c8ba31 to 03388a5 Compare

October 11, 2021 10:07

framsouza closed this

framsouza reopened this

jmlrt self-requested a review

October 11, 2021 10:37

framsouza force-pushed the master branch from 03388a5 to 024dd6b Compare

October 11, 2021 10:38

framsouza closed this

framsouza reopened this

framsouza force-pushed the master branch from 024dd6b to 75af2db Compare

October 11, 2021 10:43

framsouza closed this

framsouza reopened this

framsouza force-pushed the master branch 3 times, most recently from 6b05d3e to ae8f7d0 Compare

October 11, 2021 10:50


          Adding support to Ingress networking.k8s.io/v1

framsouza force-pushed the master branch from ae8f7d0 to 3219977 Compare

October 11, 2021 10:50

framsouza added 2 commits

October 11, 2021 13:22


          Adjusting ES service name

ca298fd


          Removing ingress typo & adjusting python test

1caaa02

jmlrt suggested changes

View reviewed changes

Member

jmlrt left a comment

Thanks for this PR @framsouza, note that most comment I did for apm-server/templates/ingress.yaml are also valid for the other charts

apm-server/templates/ingress.yaml Show resolved Hide resolved

apm-server/templates/ingress.yaml Outdated Show resolved Hide resolved

apm-server/templates/ingress.yaml Show resolved Hide resolved

apm-server/templates/ingress.yaml Show resolved Hide resolved

apm-server/templates/ingress.yaml Show resolved Hide resolved

elasticsearch/values.yaml Outdated Show resolved Hide resolved

elasticsearch/values.yaml Outdated Show resolved Hide resolved

kibana/values.yaml Outdated Show resolved Hide resolved

kibana/values.yaml Show resolved Hide resolved


          Adjusting python tests to use the new ingress version

4b2b7bf

Member

jmlrt commented Oct 12, 2021

Following #1410 merge, we don't need to support anymore K8S 1.18, so we may avoid using semverCompare in several places. However, we still need to find a way to ensure some kind of backward compatibility for the upgrade when using the ingress backend syntax with serviceName and servicePort.

jmlrt added feature apm-server elasticsearch kibana logstash labels

jmlrt merged commit 57aa59a into elastic:main

jmlrt mentioned this pull request

Update apiVersion to networking.k8s.io/v1 on ingress resources #1233

Closed

jmlrt added need-backport v7.16.0 labels

framsouza deleted the master branch

October 14, 2021 09:35

leifcr mentioned this pull request

Ingress pr 1409 should be merged into 7.x branch #1445

Closed

lapwat mentioned this pull request

no matches for kind "Ingress" in version "networking.k8s.io/v1beta1" #1452

Closed

jmlrt added v7.16.1 and removed v7.16.0 labels

jmlrt mentioned this pull request

[7.16] [all] Add support to ingress networking.k8s.io/v1 & ingressClassName (#1409) #1478

Merged

jmlrt added the backported label

jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request


          [all] Add support to ingress networking.k8s.io/v1 & ingressClassName (e…

cdf7c01

…lastic#1409)

* Adding support to Ingress networking.k8s.io/v1

* Adjusting ES service name

* Removing ingress typo & adjusting python test

* Adjusting python tests to use the new ingress version

* fixing conflict

* Adding support to kubernetes ingress v1 & ClassName

* Adding reformatted files

* fixing conflict

* Adding ClassName & Pathtype on ingress settings

* Performing syntax adjustments and removing comments

jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request


          [all] Add support to ingress networking.k8s.io/v1 & ingressClassName (e…

9a68669

…lastic#1409)

* Adding support to Ingress networking.k8s.io/v1

* Adjusting ES service name

* Removing ingress typo & adjusting python test

* Adjusting python tests to use the new ingress version

* fixing conflict

* Adding support to kubernetes ingress v1 & ClassName

* Adding reformatted files

* fixing conflict

* Adding ClassName & Pathtype on ingress settings

* Performing syntax adjustments and removing comments

This was referenced Dec 14, 2021

[7.x] [all] Add support to ingress networking.k8s.io/v1 & ingressClassName (#1409) #1479

Merged

[elasticsearch] fix a lines order in example values #1480

Merged

jmlrt added a commit to jmlrt/helm-charts that referenced this pull request


          [elasticsearch] fix a lines order in example values

470d699

Relates to elastic#1409

jmlrt removed the need-backport label

jmlrt added a commit that referenced this pull request


          [elasticsearch] fix a lines order in example values (#1480)

d0ecd2c

Relates to #1409

jmlrt added a commit to jmlrt/helm-charts that referenced this pull request


          [elasticsearch] fix a lines order in example values (elastic#1480)

1b24fb6

Relates to elastic#1409

jmlrt added a commit to jmlrt/helm-charts that referenced this pull request


          [elasticsearch] fix a lines order in example values (elastic#1480)

fda28d2

Relates to elastic#1409

jmlrt added a commit that referenced this pull request


          [all] Add support to ingress networking.k8s.io/v1 & ingressClassName (#…

1459b2f

…1409) (#1478)

* Adding support to Ingress networking.k8s.io/v1

* Adjusting ES service name

* Removing ingress typo & adjusting python test

* Adjusting python tests to use the new ingress version

* fixing conflict

* Adding support to kubernetes ingress v1 & ClassName

* Adding reformatted files

* fixing conflict

* Adding ClassName & Pathtype on ingress settings

* Performing syntax adjustments and removing comments

Co-authored-by: framsouza <[email protected]>

jmlrt added a commit that referenced this pull request


          [all] Add support to ingress networking.k8s.io/v1 & ingressClassName (#…

c24e00c

…1409) (#1479)

* Adding support to Ingress networking.k8s.io/v1

* Adjusting ES service name

* Removing ingress typo & adjusting python test

* Adjusting python tests to use the new ingress version

* fixing conflict

* Adding support to kubernetes ingress v1 & ClassName

* Adding reformatted files

* fixing conflict

* Adding ClassName & Pathtype on ingress settings

* Performing syntax adjustments and removing comments

Co-authored-by: framsouza <[email protected]>

jmlrt added a commit that referenced this pull request


          [elasticsearch] fix a lines order in example values (#1480) (#1483)

0cab81c

Relates to #1409

jmlrt added a commit that referenced this pull request


          [elasticsearch] fix a lines order in example values (#1480) (#1484)

27f568e

Relates to #1409

jmlrt mentioned this pull request

7.16.1 release changelog #1487

Merged

jmlrt mentioned this pull request

7.17.1 bump #1609

Merged

jmlrt mentioned this pull request

7.17.3 bump #1649

Merged

This was referenced Sep 14, 2022

[meta] fix yaml indent #1698

Merged

[meta] follow-up of #1698 #1700

Merged

jmlrt mentioned this pull request

[elasticsearch] Replace apiVersion networking.k8s.io on ingress.yaml #1672

Closed

4 tasks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

apm-server backported elasticsearch feature kibana logstash v7.16.1