This repository has been archived by the owner on May 16, 2023. It is now read-only.
Fixup security install docs #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for testing it out. I'm going to pick up #27 and make sure that all secrets are generated on the fly during the automated testing. This will make sure that the examples will work for CI and for users. |
Fixes: #193 The default makefile target was switched at some point in time to also include installing secrets from our secret service. This obviously doesn't work so good for users.
Crazybus
force-pushed
the
alright_keep_your_secrets
branch
from
a31fc98 to
6c53336
Compare
Closes: #27 This makes it possible to run all of the examples without needing to connect to our secret service, or generate the certificates and create the secrets manually.
Crazybus
force-pushed
the
alright_keep_your_secrets
branch
from
6c53336 to
662171e
Compare
This gets really tricky when you are doing docker in docker because the host path of the host doesn't match up properly with the host of the local machine. This also means that we can remove the "run as the current user id" hack to make sure that mounted files were accessible by the hosted user.
Crazybus
force-pushed
the
alright_keep_your_secrets
branch
from
0f2a564 to
cb718a9
Compare
Crazybus
changed the title
|
@mounaBoo Can you add some more information for me? I can't really do a whole lot with a "this failed" log message. Some information that would help me:
|
I am using Kubernetes goversion:"go1.10.8b4", Compiler:"gc", Platform:"linux/amd64"} helm get helm-kibana-security : |
|
helm get helm-es-security : |
|
kubctl get pods : |
|
kubectl get secrets # also check that these secrets seem to have the correct output kubectl logs -l release=helm-kibana-security no logs appear |
|
This line tells me that you aren't running the version from this branch. These lines are now removed and the certificates are generated automatically. Can you make sure you are running this from the |
|
OK I will do it right now , I will clean up what I have and then report you back |
This was referenced Jul 9, 2019
|
I installed from the banche you proposed, when I run the test with make goss I ama getting this errors : I exposed the deployement for test and to visualize the dashboard so I can see the login into the UI enabled but then it could connect. this the message I am getting in my navigator :
the whole output of make goss : |
The last part of the logs show that this actually worked! The errors that you are seeing are because goss does retries on failure. Thank you for taking the time to test that this is actually working for someone besides me and the CI system. From a bootstrapping point of view it looks like it is working for you. My suspicion is that you might have some other issues (e.g. with slow storage) that is causing things to be flaky. Could you open a separate issue with more detail so that we can investigate that further? |
|
ok I opened a new issue with more information about the error I am getting https://localhost:5601/app/kibana: status: Error #219 |
mounaBoo
reviewed
Jul 11, 2019
| # Get the auto generated password | ||
| kubectl get secret elastic-credentials -o jsonpath='{.data.password}' | base64 --decode | ||
| kubectl port-forward deployment/helm-kibana-default-kibana 5601 |
There was a problem hiding this comment.
kubectl port-forward deployment/helm-kibana-default-kibana 5601 sir I have a question about that don't you mean by that :
kubectl port-forward deployment/helm-kibana**-security-**kibana 5601
There was a problem hiding this comment.
Yes, that is exactly what is in the code. I think you are looking at the part of the diff that was deleted rather than the new line which was added below.
There was a problem hiding this comment.
that's ok it wasn't updated at the time I looked at it. but still having problem with kibana UI
tylerjl
approved these changes
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #193
The default makefile target was switched at some point in time to also
include installing secrets from our secret service. This obviously
doesn't work so good for users.
I took this as an opportunity to also pick up #27 by making sure that all secrets are generated fresh for each CI run. By using the same target for CI as the user documentation we can be sure that the docs won't go out of date again.