Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backgrounds of fallback avatars in pills in the composer have gone black #13478

Closed
ara4n opened this issue May 2, 2020 · 7 comments · Fixed by matrix-org/matrix-react-sdk#4553
Closed

backgrounds of fallback avatars in pills in the composer have gone black #13478

ara4n opened this issue May 2, 2020 · 7 comments · Fixed by matrix-org/matrix-react-sdk#4553
Assignees
@bwindels
Labels
A-Pills T-Defect X-Regression X-Release-Blocker

Comments

@ara4n
Copy link
Member

ara4n commented May 2, 2020

No description provided.

@ara4n
Copy link
Member Author

ara4n commented May 2, 2020

Screenshot 2020-05-02 at 01 58 36

@jryans
Copy link
Collaborator

jryans commented May 4, 2020

@ara4n This is for the case of user with avatar but can't be loaded due to network / server issues?

The case of user who has no avatar set at all seems to be working at least.

@jryans jryans added the X-Needs-Info This issue is blocked awaiting information from the reporter label May 4, 2020
@nadonomy
Copy link
Contributor

nadonomy commented May 5, 2020

+1, am seeing this too.

@turt2live
Copy link
Member

this sounds a bit like matrix.org being slow and causing requests to stack up, so the request for the image which runs the background there is blocked.

@turt2live
Copy link
Member

oh, this is only in the composer.

@turt2live turt2live removed X-Cannot-Reproduce X-Needs-Info This issue is blocked awaiting information from the reporter labels May 5, 2020
@bwindels
Copy link
Contributor

bwindels commented May 6, 2020

I assume this regressed in matrix-org/matrix-react-sdk#4503, will have a look.

@bwindels
Copy link
Contributor

bwindels commented May 6, 2020

Can repro in Firefox, the data url for the background gets a ../../ prepended and doesn't render.

@bwindels bwindels mentioned this issue May 6, 2020
Merged
@jryans jryans added the A-Pills label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
A-Pills T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove prefixes for composer avatar urls matrix-org/matrix-react-sdk
5 participants
@bwindels @jryans @turt2live @ara4n @nadonomy