-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support overriding parts of config.json via .well-known #13678
Comments
|
Please don't allow the homeserver owner (or bad actor) to override local settings, especially when it comes to privacy settings. I think the idea for providing default settings - which are overridden by the local config.json - is great though. Riot desktop could ship with a defaults-only config.json to practically achieve the first behavior, while still allowing people to control the software on their computer. |
is that currently already possible? i see no security concers as long as you can override with a local config.json. It would be cool to have a Import wizard for the suggested settings from the well-known homeserver at first Riot launch. i would set it like (does actually not work for me):
i' not sure about the im.vector.riot object? it it correct? |
This issue is still open, so not implemented, so no your attempt is not correct |
ok, thanks for clarify. keep on your good work :) |
Any chance to at least support the Jitsi preferred domain configuration on the desktop client? |
@majordave https://github.com/vector-im/riot-web/blob/develop/docs/jitsi.md#configuring-element-to-use-your-self-hosted-jitsi-server already specifies how that can be done. |
@turt2live I asked because I have already set my /.well-known/matrix/client as specified there but it didn't work, I still get the default domain unless I change the config.json on the desktop client. Which isn't feasible for every one of my users. |
Then you have a different bug. |
Is any plans to support this. Would be nice to have a custom permalink URL in the desktop and Mobile clients. Why is it matrix.to in the first place? It should just default to the server URL. |
This is a thing that I've considered proposing for a while given there's various minor settings that could be homeserver-specific and need to support desktop users. Now that we're encouraging the desktop app more, we should probably have a way for homeservers to say "my theme is CoolCompany Blue" instead of light, for example.
Some ideas for things that could be covered by this:
settingDefaults
Stuff like the homeserver/identity server wouldn't matter at this point in the cycle as it's something that should be checked much earlier in the app.
The shape of this could possibly just be an
im.vector.web.settings
object which just gets lumped on top of the in-memory config.Outstanding questions:
a. If we do check regularly, what do we do if a setting changes? eg: if the theme changes, it might be jarring to have the theme suddenly change without warning. Maybe a prompt to "update", getting the user to reload the app?
assigned to myself because I'm interested in making a proof of concept regardless of question 4.
The text was updated successfully, but these errors were encountered: