Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should probably avoid setting nonsensical state events #13901

Closed
turt2live opened this issue Jun 3, 2020 · 1 comment
Closed

We should probably avoid setting nonsensical state events #13901

turt2live opened this issue Jun 3, 2020 · 1 comment

Comments

@turt2live
Copy link
Member

Particularly for critical events like the power levels: if we don't have the power levels, or the user who is about to change them might unknowingly lose power, we should prevent that request from going through. An example is a homeserver sending a partial/no power level event and the user modifying some permission within that - because we copy the event from cache, riot will take the empty object, change the permission, then send over the new object. This leads to the user losing power unknowingly.

@turt2live
Copy link
Member Author

Duplicate of #13900

Github bot be slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant